DNCrane
Is this repo dead?
Hi to all, looking at the code frequency, I am wondering if this repo is dead? Did people move on? Is there another good implementation of a cover tree out there? Or should we fork/clone and continue letting this baby live?? Best, P
I used this repository as a reference when I first started learning about cover trees, but have moved on and no longer actually use this repo.
I do have a pull request out there for a change that would eliminate the need to know the max level of the dataset before loading the tree. The max level is determined/updated dynamically as nodes are added. If you choose to fork the tree for your needs, you may want to consider picking up that pull.
mike
On Dec 12, 2017, at 10:48 AM, Peter Steinbach [email protected] wrote:
Hi to all, looking at the code frequency, I am wondering if this repo is dead? Did people move on? Is there another good implementation of a cover tree out there? Or should we fork/clone and continue letting this baby live?? Best, P
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DNCrane/Cover-Tree/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYN_9M_oEYYJzFDBo2-IXtBMt_o-GQSks5s_qBRgaJpZM4Q_Lyp.
@mikemayer67 but you are not the maintainer of this repo? Hence your PR was never merged.
I'll think about doing a hard fork. I am interested in extending the cover tree implementation to query the nearest neighbors within a range along the metric and not the rank k nearest neighbors.
I thought my branch would be visible. If you do a hard fork, you might want to pull my commits. If not, never mind. If you cannot see my branch and are interested in seeing my changes, let me know and I’ll send you a link
On Wed, Dec 13, 2017 at 03:39 Peter Steinbach [email protected] wrote:
@mikemayer67 but you are not the maintainer of this repo? Hence your PR was never merged.
I'll think about doing a hard fork. I am interested in extending the cover tree implementation to query the nearest neighbors within a range along the metric and not the rank k nearest neighbors.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/DNCrane/Cover-Tree/issues/8#issuecomment-351321474, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYN_3T_AArjHB2XT1_2TgF11Lu307QOks5s_40vgaJpZM4Q_Lyp .
-- Always code like the person who will maintain it is a psychopath who knows where you live. (corollary: s this is often myself, this is certainly true…)
I've merged both of your pull requests. Sorry for taking so long with it. If you submit in the future I'll try to get to them more quickly.
@DNCrane thanks a bunch. The question remains: how much time do you have to attend to this repo? And on top, do you have any plans to extend functionality of the covertree, i.e. do a nearest neighbor search based on distance rather than rank.
Best, psteinb
I wish this project would continue, I've liked a lot this implementation since I could integrate it easily into my project with custom distances through template parameters.
I hope that in the future I'll have more time to contribute to it or make my own version, this one is still badly optimized since I've tested it with my own implementation of knn and it performed poorly against brute force, but the code design looks neat as a saw when I integrated it to my project.
