Cover-Tree icon indicating copy to clipboard operation
Cover-Tree copied to clipboard

moving to C++11 and beyond?

Open psteinb opened this issue 7 years ago • 1 comments

I just replaced all the use of std::pair with using std::tuple and got a 30% speed improvement on insert calls:

--------------------------------------------------------------
Benchmark                       Time           CPU Iterations
--------------------------------------------------------------
BM_insert/100             4009190 ns    3993675 ns        175
BM_insert/200            14098351 ns   14066840 ns         50
BM_insert/500            79044530 ns   78869829 ns          9
BM_insert_improved/100    5105467 ns    5094695 ns        138
BM_insert_improved/200   18299317 ns   18259001 ns         38
BM_insert_improved/500  105163774 ns  104951121 ns          7

@DNCrane are you interested in such improvements and hence interested in moving to a more recent standard?

psteinb avatar Feb 09 '18 16:02 psteinb

Dear all,

@DNCrane was so generous to allow me to become a collaborator on this project. As I am using this project in my daily work, I am planning on the following tasks in the coming days:

  • lift the required C++ standard to C++11/C++14
  • provide a test suite using catch2
  • add a license to the code
  • improve the performance of the implementation (see this issue to get an idea)

If I get all of this done, I'll drop it in dedicated PRs and merge them early next week, Feb 19. If you have any feedback on it, I am happy to receive it.

psteinb avatar Feb 12 '18 11:02 psteinb