Dhruv Nair

Results 205 comments of Dhruv Nair

Thank you @tolgacangoz @a-r-r-o-w Could you take a look please

@Sundragon1993 I think you have to run `make style && make quality` on the PR and push up the changes.

Since #8542 was merged, can we close this?

@tongyu0924 Is this ready for review? If so, could you move the pipeline under `src/diffusers/pipelines/pag` please and make the changes needed to import the pipeline?

Thank you @tongyu0924 👍🏽! Could we add the pipeline to the necessary init files PAG Module: https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/pag/__init__.py Pipelines Module: https://github.com/huggingface/diffusers/blob/049082e013fb71d78f3abf487916f3de2b674908/src/diffusers/pipelines/__init__.py#L175 Diffusers main init https://github.com/huggingface/diffusers/blob/049082e013fb71d78f3abf487916f3de2b674908/src/diffusers/__init__.py#L341 And then could you please add...

btw @sayakpaul This line ``` self.safetensors_file_path = os.path.join(self.offload_to_disk_path, f"group_{id(self)}.safetensors") ``` Uses the memory address of the group object to create the filename, but that can change across sessions. So you...

Hi @Rockstar292 thanks for flagging. Skipping the tests in the CI for now until we resolve the repo issue.

Would be better to add a utility function ```python def _should_convert_state_dict_to_diffusers(model_state_dict, checkpoint_state_dict): return not set(model_state_dict.keys()).issubset(set(checkpoint_state_dict.keys()) ``` to `single_file_model.py`. If condition passes, convert the checkpoint with this line https://github.com/huggingface/diffusers/blob/d7dd924ece56cddf261cd8b9dd901cbfa594c62c/src/diffusers/loaders/single_file_model.py#L375 if not...

@sayakpaul This should be good to merge. Would work well for QwenImage (need to add single file mixin to the model) if you want to give it a try.

@josemerinom Thanks for reporting. Opened a PR to fix #8753