roadmap

roadmap copied to clipboard

A bug related to the feedback-request feature was reported to the DMPonline team by an org-admin (OA) user. ## Description of the bug The following is a high-level description of...

don-stuckey

This issue is documented at https://github.com/portagenetwork/roadmap/issues/1061 but also exists within this codebase.

aaronskiba

Changes proposed in this PR: - Prior to this change, rather than assigning the desired role to the newly created plan, executing `create(:plan, :creator...` or `create(:plan, :commenter...` would create a...

aaronskiba

Conditional question fix for removing questions bug rails7

5

A Conditional Question (with action: "remove" and in a Phase with multiple sections) for this bug can be described structurally as follows: ``` Conditional Question: Q2. Will your data be...

johnpinto1

Fixes #3396 Changes proposed in this PR: - Prior to this change, `config/database.yml` was configured such that running tests would be executed against the dev db. This would result in...

aaronskiba

Add codespell support (config, workflow to detect/not fix) and make it fix some typos

2

More about codespell: https://github.com/codespell-project/codespell . I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback. CI workflow has 'permissions' set only to...

yarikoptic

### Affected Version - Release `v5.0.0` and persists on https://github.com/DMPRoadmap/roadmap/pull/3516 ### Steps to Replicate 1. Save checkbox with question options and conditions:  2. Update answer format...

aaronskiba

Refactor `AnswersController#create_or_update`

1

Changes proposed in this PR: - Refactor `AnswerController#create_or_update` - The majority of this refactor extracts logic from the `create_or_update` action into separate private helper methods (commits 609d5df3b8a66d1a2adc739a9b8fde038a3de72d, efecb337795f999de6679576cd3fd7ee0a5683f3, and a840abb1415e64888e51b1fdc268f550e8f1f4bb)...

aaronskiba

When using Spring v4.3.0, I encountered the following error when starting the Rails console: ``` $ bin/spring stop && rails c Spring is not running /usr/share/rvm/gems/ruby-3.0.5@dmp/gems/railties-7.1.5.1/lib/rails/railtie.rb:228:in `method_missing': undefined method `root'...

aaronskiba

## Issue Description In the `OmniauthCallbacksController`, an unassigned variable appears to be referenced in the following code: In `app/controllers/users/omniauth_callbacks_controller.rb`, line 57-58: ```ruby flash[:alert] = _("The current #{scheme.description} iD has been...

aaronskiba