roadmap
roadmap copied to clipboard
Fix Flaky Tests / Optimize Checking of `plan.title` Within `spec/features/plans/exports_spec.rb`
Fixes #3450
Changes proposed in this PR:
- Fixes the flaky tests within
spec/features/plans/exports_spec.rb(see #3450)- While inspecting these sometimes failing tests, it was found that
expect(page.source).to have_text(plan.title)sometimes failed because sometimespage.source == "". - Rather than
page.source, which returns the entire HTML content of the page, this PR usespage.title, which only returns the contents inside of the<title>tags.page.titledoes not seem to encounter the unwanted behaviour of returning a blank string. Maybe because it is faster (only returning the title should be faster than returning the entire HTML content viapage.source)?- Also, the
<title>title tags and their contents are part of the entire HTML content. So despitepage.sourcereturning a blank string, becausepage.titleis not blank, it follows that the DOM is not blank.
- While inspecting these sometimes failing tests, it was found that