roadmap icon indicating copy to clipboard operation
roadmap copied to clipboard

Address Rendered Message When 'Feedback Request' is Successfully Sent on a Plan

Open aaronskiba opened this issue 5 months ago • 0 comments

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

  • v4.1.1

Explanation Rather than receiving a generic success message, the rendered notice is a copy of the feedback request message.

  • Screenshot 2024-01-24 at 1 39 00 PM

I'm not sure exactly if or how we should address this. Maybe the success message notification can be kept, but the Your plan "{plan_name}" has been submitted... message rendered within the body of the page (see below image) should be removed?

  • Screenshot from 2024-02-05 08-20-10

Corresponding Code

  # Flash notice for successful feedback requests
  #
  # Returns String
  def request_feedback_flash_notice
    # Use the generic feedback confirmation message unless the Org has
    # specified one
    text = current_user.org.feedback_msg || feedback_confirmation_default_message
    feedback_constant_to_text(text, current_user, @plan, current_user.org)
  end

aaronskiba avatar Jan 24 '24 20:01 aaronskiba