roadmap icon indicating copy to clipboard operation
roadmap copied to clipboard

Incorrect French abbreviation in seeding, making French translation unusable.

Open Sean-Stilwell opened this issue 1 year ago • 1 comments

What version of the DMPRoadmap code are you running? (e.g. v2.2.0) v3.1.1

Expected behaviour: French translated version opens when changing language in the language toggle.

Actual behaviour: Reverts to the default (en-GB for me) version. This does not occur with the Spanish, German, Turkish, or Portuguese translations (i.e it's exclusive to French).

Cause: In db/seeds.rb, the following is a value from the languages array:

{abbreviation: 'fr',
   description: '',
   name: 'Français',
   default_language: false},

The 'fr' abbreviation should be replaced by either 'fr-FR' or 'fr-CA'. Manually updating this value in my database to either abbreviation corrected this issue for me.

Sean-Stilwell avatar Aug 11 '22 17:08 Sean-Stilwell

Thanks @Sean-Stilwell would you be will to send a PR to update this for us?

briri avatar Aug 31 '22 14:08 briri