"select guidance" in plan editor should have a selectbox for organisations with subcategories

[nicolasfranck]

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

3.0.2

Expected behaviour:

In /plans/:id the guidance selector should display a selectbox for organisations that have subcategories.

Actual behaviour:

The guidance selector does not display a selectbox for organisations that have subcategories. This generates two problems:

• the title seems to belong to a previous item at the same level that does have a selectbox (e.g. organisation-2-with-sub-categories seems to be part of organisation-1-without-sub-categories)

[] organisation-1-without-sub-categories
   organisation-2-with-sub-categories
    [] category-1
    [] category-2

• if one does add a selectbox, obviously this would have to enable/disable the selectboxes beneath it.

[nicolasfranck]

or merely show a table with "org" and "name of guidance group"

[briri]

related to #1166 and #2589

Yes, user guidance selection needs some serious work. We have had a few discussions about how best to deal with this. The Project details page is getting quite crowded and users often miss the guidance selection entirely. It would also make sense to update the admin's Guidance page to replace the optional_subset flag with an association to a department at this point.

@nicolasfranck do you have any thoughts on how this could be improved? Does it warrant its own tab (moving it off of the project details tab) or a modal dialog perhaps? I believe the "default" guidance group and the "Research Org" the user specifies are auto-selected when the plan is created but it might be useful to add department logic here.

[nicolasfranck]

I would make the behaviour the same everywhere:

• option 1: do not add a checkbox to the organization headings, but always show the guidance groups with checkboxes, even if there is only one. This way the layout is always clear. And if the guidance group has a name different from the organization's name, it is always shown (it is hidden now if there is only one guidance group).

* Org-1:
  * [ ] guidance group 1
* Org-2:
  * [ ] guidance group 2
  * [ ] guidance group 3

• Option 2: same as option 1, but now add a checkbox to the organization header too, and let javascript select all guidance groups below it when checked:

* [ ] Org-1:
  * [ ] guidance group 1
* [ ] Org-2:
  * [ ] guidance group 2
  * [ ] guidance group 3

I know, it would make it longer for those who have only one guidance group. But the advantages are the following:

• layout is clear: organization and its guidance groups
• you're not adding organizations but guidance groups (it looks like that now)
• if you have a specific name for your single guidance group, at least that is shown (which is not now)