online-judge icon indicating copy to clipboard operation
online-judge copied to clipboard

Show Problem Types In Contest When Enabled

Open tandr3w opened this issue 10 months ago • 6 comments

Fixes #1872 (or attempts to)

tandr3w avatar Apr 02 '24 01:04 tandr3w

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 46.76%. Comparing base (a981a64) to head (9c69413). Report is 1 commits behind head on master.

Files Patch % Lines
judge/views/problem.py 33.33% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
- Coverage   46.76%   46.76%   -0.01%     
==========================================
  Files         251      251              
  Lines       13317    13320       +3     
==========================================
+ Hits         6228     6229       +1     
- Misses       7089     7091       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 02 '24 01:04 codecov-commenter

can you post screenshots of the old and new problem list?

int-y1 avatar Apr 02 '24 03:04 int-y1

Before: image

After: image

tandr3w avatar Apr 02 '24 03:04 tandr3w

  • Moved show_types change into the setup_problem_list function
  • Replaced zip with an annotation
  • Fixed inconsistent padding due to the in-contest types table header not having the "types" class

tandr3w avatar Apr 04 '24 14:04 tandr3w

New Screenshots:

Before changes: image

With types disabled, after changes image

With types enabled, after changes image

tandr3w avatar Apr 04 '24 19:04 tandr3w

Ready for re-review image

tandr3w avatar Apr 06 '24 16:04 tandr3w