online-judge
online-judge copied to clipboard
Show Problem Types In Contest When Enabled
Fixes #1872 (or attempts to)
Codecov Report
Attention: Patch coverage is 33.33333%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 46.76%. Comparing base (
a981a64
) to head (9c69413
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
judge/views/problem.py | 33.33% | 4 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #2327 +/- ##
==========================================
- Coverage 46.76% 46.76% -0.01%
==========================================
Files 251 251
Lines 13317 13320 +3
==========================================
+ Hits 6228 6229 +1
- Misses 7089 7091 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
can you post screenshots of the old and new problem list?
Before:
After:
- Moved show_types change into the setup_problem_list function
- Replaced zip with an annotation
- Fixed inconsistent padding due to the in-contest types table header not having the "types" class
New Screenshots:
Before changes:
With types disabled, after changes
With types enabled, after changes
Ready for re-review