online-judge icon indicating copy to clipboard operation
online-judge copied to clipboard

Private contest for classes not working

Open FherStk opened this issue 2 years ago • 7 comments

Dear DMOJ team,

I'm setting up a contest with the following config:

  • Private for organization (it's open to join).
  • Private for class (I have 3 classes with access code).

First issue:

  • The request to join a class displays just the request message, which must be manually approved. I cannot find where to join using the access code.

Second issue:

  • The contest is being displayed for everyone within the organization despite the class (the user is not enrolled in any class, just in the organization).

Thanks again for your help and support, Fher

FherStk avatar Dec 14 '22 09:12 FherStk

  1. Joining classes by access code is not currently implemented. I'll add it soon.
  2. For a contest to be visible to a single class, nothing should be added to the list of organizations with access. Can you try it without any organization on the contest, just classes?

quantum5 avatar Dec 14 '22 22:12 quantum5

Hi,

  1. Thanks, it will be great :)
  2. This is the behavior:
  • Contest visible + organization + class:

    • User belongs to organization + class -> can see the contest.
    • User belongs to organization (only) -> can see the contest.
  • Contest visible + organization only:

    • User belongs to organization + class -> can see the contest.
    • User belongs to organization (only) -> can see the contest.
  • Contest visible + class only:

    • User belongs to organization + class -> can see the contest.
    • User belongs to organization (only) -> can see the contest.

Thanks again for your help, Fher

FherStk avatar Dec 15 '22 21:12 FherStk

For the contest visibility issue, this seems to be a regression introduced by #1830. It should be fixed in #2065. After patching it in, you'll need to remove all the classes, save the contest, then add them back for it to take effect. Sorry for the inconvenience.

quantum5 avatar Dec 16 '22 07:12 quantum5

Thanks and don't feel worry, you're doing a wonderful job, I'm delighted with DMOJ!

Thanks again, Fher

FherStk avatar Dec 16 '22 15:12 FherStk

For the contest visibility issue, this seems to be a regression introduced by #1830. It should be fixed in #2065. After patching it in, you'll need to remove all the classes, save the contest, then add them back for it to take effect. Sorry for the inconvenience.

Hi there,

With "remove all the classes" you mean remove those from the contest or remove entirely from the system?

Thanks again for your time, Fher

FherStk avatar Dec 25 '22 12:12 FherStk

With "remove all the classes" you mean remove those from the contest or remove entirely from the system?

Remove from contest is sufficient.

quantum5 avatar Dec 25 '22 12:12 quantum5

Hi,

I tried again and this is the behavior I got:

Contest with organization only + user with organization and class: user can see the contest. Contest with organization and class + user with organization and class: user can see the contest. Contest with class only + user with organization and class: user can't see the contest.

Contest with organization only + user with organization only: user can see the contest. Contest with organization and class + user with organization only: user can see the contest. Contest with class only + user with organization: user can't see the contest.

I accepted or rejected the request to join the class in order to test the behavior, but the contest was always visible event when no class was setup for the user. What am I missing?

Thanks again and happy new year! Fher

FherStk avatar Jan 02 '23 11:01 FherStk