online-judge icon indicating copy to clipboard operation
online-judge copied to clipboard

Refactor user submission table's js

Open int-y1 opened this issue 2 years ago • 3 comments

JS's ngettext doesn't work in templates/, so move it to resources/.

i18n: python manage.py makemessages -l en -d djangojs detected all 5 i18n strings and put them in djangojs.po.

JS compatibility: The submission table works in IE11. (This required a lot of small changes)

Capture

int-y1 avatar Jun 04 '22 03:06 int-y1

Codecov Report

Merging #1954 (c745bd8) into master (966b37d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1954   +/-   ##
=======================================
  Coverage   46.46%   46.46%           
=======================================
  Files         236      236           
  Lines       13114    13114           
=======================================
  Hits         6093     6093           
  Misses       7021     7021           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 966b37d...c745bd8. Read the comment docs.

codecov-commenter avatar Jun 04 '22 03:06 codecov-commenter

I feel like "not working in IE" is totally fine (iirc MS is going to deprecate IE mode soon:tm:)

kiritofeng avatar Jun 06 '22 18:06 kiritofeng

I feel like "not working in IE" is totally fine (iirc MS is going to deprecate IE mode soon™️)

I did it to prevent https://github.com/DMOJ/online-judge/commit/fc25c65afc54d028b346ddfa8cdbb099391447d2 from happening again.

int-y1 avatar Jun 06 '22 18:06 int-y1