online-judge icon indicating copy to clipboard operation
online-judge copied to clipboard

Make Ctrl+Click link open raw source instead

Open zecookiez opened this issue 4 years ago • 5 comments

Fixes #1545

zecookiez avatar Oct 02 '20 15:10 zecookiez

Codecov Report

Merging #1560 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1560   +/-   ##
=======================================
  Coverage   46.10%   46.10%           
=======================================
  Files         210      210           
  Lines       12074    12074           
=======================================
  Hits         5567     5567           
  Misses       6507     6507           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00c792f...00d58ce. Read the comment docs.

codecov-commenter avatar Oct 02 '20 15:10 codecov-commenter

IMO should not open in new tab for consistency.

kiritofeng avatar Oct 02 '20 21:10 kiritofeng

Between @quantum5 and I, it seems that just adding this as another link is preferred. It removes any inconsistencies with how browsers normally behave, is more visible to public users, and just so happens to line up with the amount of space taken up by links in the non-raw source page.

Edit: Others disagree.

fluix-dev avatar Oct 02 '20 21:10 fluix-dev

In this case will updating the title of this PR be sufficient, or should this be closed for a separate one to be opened to reflect the proposed changes? I apologize in advance for my lack of experience with this :s

zecookiez avatar Oct 02 '20 22:10 zecookiez

Because people don't want a link, I think it's best to change Ctrl to a different key like Shift, but this really just requires more discussion from the other contributors.

Edit: AKA, don't do anything yet :stuck_out_tongue:

fluix-dev avatar Oct 02 '20 22:10 fluix-dev