tangle-accelerator icon indicating copy to clipboard operation
tangle-accelerator copied to clipboard

feat(Endpoint): Implement WP76xx platform

Open splasky opened this issue 5 years ago • 8 comments

The FX30 gateway used the WP76xx platform. We should implement it.

splasky avatar Jul 16 '20 08:07 splasky

Analyze the impact to existing HAL and adaption layer.

jserv avatar Jul 16 '20 08:07 jserv

Never write code in a rush. Always think of the portability, code reusability, and elegance.

jserv avatar Jul 16 '20 08:07 jserv

The Legato AF provides the "simu" directory for generate test stub. The test stub can replace the HAL inside endpoint. So we only need one "impl.c" in endpoint for all platform. The HAL could be removed after the test passed(#707). However, when executed the endpoint binary. It will generate the error message "Failed to load library 'libComponent_endpointComp.so".

The attribute for different platform like wp77xx,wp76xx. We can set the attribute inside another definition files and import the setting when build the app for the target.

The test scripts for different platform like test-WP77.sh test-WP76.sh will be merged. The build scripts for different platform will be merged.

splasky avatar Jul 27 '20 05:07 splasky

After I tried to use the simu as platformService test stub provided by the Legato AF. It would raise some weird error during compiling. So I think it is better to define the simulator as test stub will be more easily.

But I think we won't need HAL anymore. We can define the impl.h for the platformService functions we need to use. And only need the simulator and the implementation for the device which legato target had already supported. Only need two platforms inside platform directory:

  • simulator: Acts as test stub
  • default: The platform had already supported by the Legato AF.

The test-WP77.sh should also change to test-legato-target.sh for test all the target on legato AF.
@jserv what do you think?

splasky avatar Jul 31 '20 10:07 splasky

Check the subject. You mentioned WP76xx platform rather than the removal of HAL!

jserv avatar Jul 31 '20 10:07 jserv

We should follow the steps:

  1. Decide the removal of HAL and validate simu substitute
  2. Adapt existing platforms for new interface;
  3. Documentation as possible;
  4. Support WP76xx;

jserv avatar Jul 31 '20 10:07 jserv

The issue of removal of HAL will be moved to #707.

splasky avatar Aug 03 '20 04:08 splasky

Block by #707

splasky avatar Aug 03 '20 04:08 splasky