DLR-SR
Nozzle.mo Documentation / v_out
Hello,
while studying Processes/Nozzle.mo i have seen that the documentation at the end of the document is in my eyes not referring to the model, descriping flow resistances in pipes.
https://github.com/DLR-SR/ThermofluidStream/blob/ef31d9a470c4115b708e3a4b9904b399a68e6d3f/ThermofluidStream/Processes/Nozzle.mo#L67
Further, i have seen that you are modeling the flow veloctiy v_out with positive values in case of positive mass flows. I would have expected, as a convention, that the flow velocity v_out is negative since it is leaving the component. I have checked the code, the sign of the variables is not influencing the solution, though (used only: v_out^2). Changing the sign of v_out, thus rather fulfills a convention than correcting errors.
https://github.com/DLR-SR/ThermofluidStream/blob/ef31d9a470c4115b708e3a4b9904b399a68e6d3f/ThermofluidStream/Processes/Nozzle.mo#L27
Let me know that you think.
Bests,
both points are true, thank you. since they are not urgent, we will fix them at a later time.
Hello,
I have just seen that in other models (see below), v_out is meant to be positive (equations based on v_out are designed for positive values of v_out). In case you are willing to introduce a convetion that v_out has negative values, you would need to adapt further models. I'm not sure, if that is in your interest ... and if there is a benefit for you.
https://github.com/DLR-SR/ThermofluidStream/blob/ef31d9a470c4115b708e3a4b9904b399a68e6d3f/ThermofluidStream/Boundaries/DynamicPressureInflow.mo#L59 https://github.com/DLR-SR/ThermofluidStream/blob/ef31d9a470c4115b708e3a4b9904b399a68e6d3f/ThermofluidStream/Boundaries/DynamicPressureInflow.mo#L71
It might be easier to add a coment, that v_out has positive values for outgoing flow.
Bests,
The documentation of Nozzle was fixed with https://github.com/DLR-SR/ThermofluidStream/commit/c34a0a4f36e47f9c1b5d1f1c14aedebf3f191a10
Thank you again, your remarks on the sign convention are reasonable. With PR #147 we have updated the documentation of the dynamic pressure components and added an explanation of the sign convention of the velocity. An internal review on changing the sign convention is still pending.
