Cross section

[AntonReiswich]

Description

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Checklist:

• [x] A test for the new functionality was added.
• [ ] All tests run without failure.
• [ ] The new code complies with the TiGL style guide.
• [ ] New classes have been added to the Python interface.
• [x] API changes were documented properly in tigl.h.

[AntonReiswich]

Thanks again for your comments!

I totally agree that we should divide the task into two parts - a calculation part and an analysis part - and in order to do so, enhance for example the CTiglIntersectionCalculation class. Since it turned out that the CTiglIntersectionCalculation class might need some refactoring, and based on our evaluation of the situation and decision this week, let us proceed as follows:

• For now, we keep the simple implementation of the API-function tiglGetCrossSectionArea from August 24th, which doesn't divide the task in a calculation and an analysis part yet, and we make sure that it works and TiGL's users can already use this functionality. To ensure that it works properly, I will add further unittests, also testing the functionality with more complex geometries as the D150. Profiling the calculation time will be enabled, as well.
• To implement the tiglGetCrossSectionArea function properly, dividing the calculation and the analysis part as well as ensuring a properly working cache functionality, I open a new issue #926 which also includes an appropriate refactoring of the CTiglIntersectionCalculation class. This will be a larger task.

[codecov-commenter]

Codecov Report

Merging #921 (8ec28fb) into master (6b764bd) will decrease coverage by 0.01%. The diff coverage is 84.61%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   69.56%   69.55%   -0.02%     
==========================================
  Files         298      298              
  Lines       24947    25013      +66     
==========================================
+ Hits        17355    17397      +42     
- Misses       7592     7616      +24     

Impacted Files	Coverage Δ
src/api/tigl.cpp	55.12% <84.61%> (+0.27%)	:arrow_up:
src/CCPACSStringVector.cpp	86.53% <0.00%> (-5.30%)	:arrow_down:
src/CCPACSEtaIsoLine.cpp	59.45% <0.00%> (-5.25%)	:arrow_down:
src/cpacs_other/CCPACSMaterialDefinition.cpp	54.54% <0.00%> (-4.72%)	:arrow_down:
src/CCPACSXsiIsoLine.cpp	15.78% <0.00%> (-2.97%)	:arrow_down:
src/CCPACSPointAbsRel.cpp	70.31% <0.00%> (-2.42%)	:arrow_down:
src/geometry/CCPACSTransformation.cpp	76.97% <0.00%> (-1.55%)	:arrow_down:
src/wing/CCPACSWingCell.cpp	78.18% <0.00%> (+0.04%)	:arrow_up:
src/cpacs_other/CTiglUIDManager.cpp	83.48% <0.00%> (+0.45%)	:arrow_up:
...c/fuselage/CCPACSFuselageStringerFramePosition.cpp	4.72% <0.00%> (+0.65%)	:arrow_up:
... and 1 more