tigl icon indicating copy to clipboard operation
tigl copied to clipboard

Update CPACS Schema to 3.3

Open joergbrech opened this issue 1 year ago • 4 comments

Description

Fixes #883.

This PR updates the CPACS schema file to 3.3.

Apart from some syntactic changes (e.g. renamed xml nodes for kinks) and some small bug fixes the following changes need to be taken into account for TiGL:

  • https://github.com/DLR-SL/CPACS/issues/680

    This is a bigger task and will be done in a separate issue: #915

  • https://github.com/DLR-SL/CPACS/issues/632

    This is a bigger task and will be done in a separate issue: #908

  • https://github.com/DLR-SL/CPACS/issues/624

    This is a bigger task and will be done in a separate issue: #909

How Has This Been Tested?

Existing unit tests and integration tests succeed, added a new unit test for the stringerFramePosition. CHecked the tiglviewer report.

Screenshots, that help to understand the changes(if applicable):

Checklist:

  • [ ] A test for the new functionality was added.
  • [x] All tests run without failure.
  • [x] The new code complies with the TiGL style guide.
  • [x] New classes have been added to the Python interface.
  • [ ] API changes were documented properly in tigl.h.

joergbrech avatar Jul 12 '22 15:07 joergbrech

Codecov Report

Merging #907 (0798911) into master (6b764bd) will increase coverage by 0.21%. The diff coverage is 48.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
+ Coverage   69.56%   69.78%   +0.21%     
==========================================
  Files         298      298              
  Lines       24947    25003      +56     
==========================================
+ Hits        17355    17448      +93     
+ Misses       7592     7555      -37     
Impacted Files Coverage Δ
src/CCPACSEtaIsoLine.cpp 59.45% <0.00%> (-5.25%) :arrow_down:
src/CCPACSStringVector.cpp 86.53% <0.00%> (-5.30%) :arrow_down:
src/CCPACSXsiIsoLine.cpp 15.78% <0.00%> (-2.97%) :arrow_down:
src/cpacs_other/CCPACSMaterialDefinition.cpp 54.54% <ø> (-4.72%) :arrow_down:
src/fuselage/CCPACSFuselageProfile.cpp 81.10% <0.00%> (ø)
src/CCPACSCurveParamPointMap.cpp 54.28% <33.33%> (ø)
...c/fuselage/CCPACSFuselageStringerFramePosition.cpp 16.66% <46.34%> (+12.60%) :arrow_up:
src/CCPACSPointAbsRel.cpp 70.31% <62.50%> (-2.42%) :arrow_down:
src/CCPACSPoint.cpp 62.90% <80.00%> (+1.49%) :arrow_up:
src/CCPACSCurvePointListXYZ.cpp 86.66% <100.00%> (ø)
... and 15 more

codecov-commenter avatar Jul 14 '22 21:07 codecov-commenter

As discussed today with @sdeinert the implementation of the stringerFramePosition must be reworked, so I re-labeled this PR as draft.

joergbrech avatar Jul 18 '22 13:07 joergbrech

@AntonReiswich, this PR is - again - ready for review.

joergbrech avatar Jul 21 '22 08:07 joergbrech

@joergbrech Great, thanks!

AntonReiswich avatar Jul 22 '22 07:07 AntonReiswich