tigl icon indicating copy to clipboard operation
tigl copied to clipboard

Problem showing an aeircraft with engine, but without nacelle

Open CLiersch opened this issue 3 years ago • 5 comments

When just applying an engine to an aircraft (here called "bothEngines") without a nacelle, TiGL-opens an error dialog box in the GUI: image

After clicking on "close", TiGL proceeds and shows the rest of the geometry - but from my perspective it should be fine to have an aircraft with engine but without nacelle (e.g. engine buried in the fuselage).

CLiersch avatar Mar 15 '21 11:03 CLiersch

I agree it should be possible. What does the CPACS standard say? Is a nacelle mandatory or optional?

rainman110 avatar Mar 22 '21 11:03 rainman110

It's optional: engineType

MarAlder avatar Mar 22 '21 11:03 MarAlder

I agree that this error message is wrong and should be fixed. In the mean time, starting with TiGL 3.2, you can suppress error messages in TiGLViewer with the command line option --suppress-errors.

joergbrech avatar Apr 30 '21 15:04 joergbrech

If I remember correctly, the problem was that we try to build a tree of RelativelyPositionedComponents. Therefore the CPACSEnginePosition was initially implemented as a RelativelyPositionedComponent, ignoring the fact that it does not necessarily contain any geometric information.

joergbrech avatar Jun 15 '22 09:06 joergbrech

The same problem occurs with pylons, can be reproduced e.g. with https://github.com/DLR-SC/tigl/blob/master/tests/unittests/TestData/CPACS_30_D250_10.xml.

joergbrech avatar Jun 15 '22 09:06 joergbrech