tigl icon indicating copy to clipboard operation
tigl copied to clipboard

Issue with combination of guide curves and fuselage kinks

Open RlanderRISCSW opened this issue 3 years ago • 4 comments

When trying to add guide curves to a model containing fuselage kinks the kink edges are not generated any more. Additionally it seems that the curve parameters defined by the kinks are not taken into account by the guide curve. Is this a bug or is the combination of guide curves and kinks not supported?

Here the example I used (cpacs files in archive): kinks_GC_issue.zip

The left image shows the original fuselage with the kink defined in the front profile at parameter 0.3 (kink_noGC.xml). The right image shows the same model with a guide curve added at parameter 0.28. kinks_noGCkinks_withGC

It looks like the kink edge is not generated when a guide curve is defined, and also the changed parameter for the kink point in the first section (0.3) ist not taken into account by the guide curve (parameter 0.28 should be above the symmetry plane in the first section)

RlanderRISCSW avatar Oct 01 '20 14:10 RlanderRISCSW

In theory, kinks and guidecurves should be compatible. I have to look into it, what causes the bug.

If you look closely, there still is the kink at param = 0.3. But the surface it not subdivided at the parameter. The reason is, that both surface creation mechanism are inherent different and this case was simply not taken into account.

rainman110 avatar Oct 05 '20 19:10 rainman110

Here's my analysis about the issue.

Actually, I see here two problems. One is a true bug, the other one is an inconvenience.

  1. Bug: The guide curve is placed a parameter = 0.28, the kink at 0.3. Thus, the guide curve should be placed above the kink. In fact, it is currently placed below.

    Calling in TiGL Viewer tigl.fuselageGetPoint(1,1, 0, 0.3) it results in a point below the kink, but it should be located at the kink! In this sense, the guide curve is positioned correctly, but the fuselage / wire parametrization is wrong!

  2. Inconvenience: The surface is not splitted at the kink. The reason is, the we currently have implemented two different face modes: First, split faces along guide curves. Second, split faces along kinks. A mix of both needs to be implemented.

rainman110 avatar Dec 14 '21 10:12 rainman110