tigl icon indicating copy to clipboard operation
tigl copied to clipboard

Add Display options in Editor

Open ole-alb opened this issue 1 month ago • 1 comments

Description

Add display options to a second tab next to the CPACS Editor

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • - [ ] yes
  • - [ ] does not apply
  • - [ ] OK
New classes have been added to the Python interface.
  • - [ ] yes
  • - [ ] does not apply
  • - [ ] OK
The code is properly documented with doxygen docstrings
  • - [ ] yes
  • - [ ] does not apply
  • - [ ] OK
Changes are documented at the top of ChangeLog.md
  • - [ ] yes
  • - [ ] does not apply
  • - [ ] OK

ole-alb avatar Dec 11 '25 15:12 ole-alb

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 72.46%. Comparing base (0788cd7) to head (0da1d6e). :warning: Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   72.47%   72.46%   -0.02%     
==========================================
  Files         313      313              
  Lines       27391    27395       +4     
==========================================
  Hits        19851    19851              
- Misses       7540     7544       +4     
Flag Coverage Δ
unittests 72.46% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 11 '25 15:12 codecov[bot]

This is a very cool addition!

I played around a bit and noticed a few small issues (without looking at the code just yet):

  • The right-click context menu and the Display Options are not in sync, this is especially apparent in the transparency slider. Using the one from the Display Options doesn't update the one from the context menu and vice-versa.
  • The context menu has one more rendering mode compared to the Display Options (textured)
  • When I have the tab "Display Options" open for one CPACS node and I select another, the tab "CPACS Editor" is open. I would expect the selected tab to persist and I see the display options for the newly selected CPACS node.
  • Feature request: Can we add a button "Reset to default" to the Display Options of each individual CPACS node?

joergbrech avatar Dec 19 '25 08:12 joergbrech

This is a very cool addition!

I played around a bit and noticed a few small issues (without looking at the code just yet):

* The right-click context menu and the Display Options are not in sync, this is especially apparent in the transparency slider. Using the one from the Display Options doesn't update the one from the context menu and vice-versa.

* The context menu has one more rendering mode compared to the Display Options _(textured)_

* When I have the tab "Display Options" open for one CPACS node and I select another, the tab "CPACS Editor" is open. I would expect the selected tab to persist and I see the display options for the newly selected CPACS node.

* Feature request: Can we add a button "Reset to default" to the Display Options of each individual CPACS node?

Done

ole-alb avatar Dec 22 '25 10:12 ole-alb