Darnell Andries

Results 10 comments of Darnell Andries

@GeetaSarvadnya These are good points. I updated the Windows test plan, P3A wiki and original issue to address your concerns. Thanks

Will smoke test P3A when builds pass

> Changes LGTM! ++ > > @DJAndries how do things look for you? This would be a great fix to land if everything is OK looks good! will do a...

> Also, has anyone seen this stack trace when exiting the browser? The crash goes away if I remove `OnProfileManagerDestroying` from `AdBlockSubscriptionDownloadManagerGetter`. This does not occur on `master`. Interesting side...

@chrismore @laurentiugruia @timchilds thoughts on which questions to add?

>Could you please add the test plan in the issue? Thanks! sorry, just added a note. unfortunately, there's no way to verify the inclusion of the refcode in the STAR...

@GeetaSarvadnya we just need to verify that the p3a metrics are sent to the existing endpoints as per usual (via `star-randsrv.bsg.brave.com`, `p3a-json.brave.com`, `collector.bsg.brave.com`)

hey @agraf , any luck on getting the patch accepted into kernel upstream?

@husobee Any updates on this by chance? Would be nice to see nitro-utils merged so we can get the STAR randomness server up and running in prod. Thanks in advance

@chrismore Should be a relatively short task