DIV-Games-Studio icon indicating copy to clipboard operation
DIV-Games-Studio copied to clipboard

[SDL2] function call bottleneck

Open daltomi opened this issue 1 year ago • 0 comments

https://github.com/DIVGAMES/DIV-Games-Studio/blob/dc8b7e5a77ba9c2cdb36fc1f1e43110ccb0207d5/src/divvideo.c#L590-L595

The problem is that the function OSDEP_UpdateRect only does internally is call OSDEP_Flip, so hare the function is being called 2 times. See: src/shared/osdep/osd_sdl2.c , branch: master

Maybe in modern computers the speed drop is not noticeable but mine is. Moving the windows or the mouse cursor is noticeable slower.

Proposal: A conditional guard should exist for the SDL2 implementation to only call one.

daltomi avatar Jul 28 '23 05:07 daltomi