DISTRHO-Ports icon indicating copy to clipboard operation
DISTRHO-Ports copied to clipboard

Published 20 hours ago • verified publisher icon DISTRHO

Patches to fix compile warnings

Open gitterdude opened this issue 5 years ago • 4 comments

When I compiled the latest git version of DISTRHO-Ports (commit 500ac85e3d10d) on Ubuntu 18.04 (gcc 7.3.0) it spewed out quite a few warnings and I've attached the fixes I used to shut them up.

I'm not that familiar with C++ , nor with the DISTRHO code, so please check if my solutions are correct before applying.

Another warning was ports/juce-opl/source/DROMultiplexer.cpp:292:21: warning: self-comparison always evaluates to false : for (int i = 0; i < i; i++) but I have no idea what "i" actually should be compared to. DISTRHO-Port-patches.tar.gz

gitterdude avatar Jun 11 '19 11:06 gitterdude

hello there, thanks for your efforts. do you mind creating a pull request? that way I can provide comments directly in the code

falkTX avatar Jun 11 '19 12:06 falkTX

I've posted 5 PRs.

I didn't do any for the ports/juce-opl/source/DROMultiplexer.cpp:292:21: warning: self-comparison always evaluates to false : for (int i = 0; i < i; i++) since I don't know what it actually should be.

gitterdude avatar Jun 18 '19 09:06 gitterdude

all is good, thanks. I will have a look at them sometime soon.

some of them could be sent upstream to the official projects I guess.

falkTX avatar Jun 23 '19 09:06 falkTX

these are applied now right? I think I merged all PRs but forgot about this ticket

falkTX avatar Jul 08 '20 00:07 falkTX