Cardinal [WIP] Add Mojo

Well this builds and the panels are now dark. I took a look at the examples of bidoo and impromptu dark and yeah I don't understand what's going on there so I just made a repo. Cheers.

Jul 05 '22 23:07 TheGuyWhoo

It is a start, but readme and license stuff needs updating too.

Jul 06 '22 16:07 falkTX

You still have the Atelier submodule there.

Also it would be "better" to do the panel graphic mods in code, rather than forking the repo with modified assets.

Jul 06 '22 16:07 dromer

one step at a time. the PR already gives a head start for these modules, which is nice :)

Jul 06 '22 16:07 falkTX

I added atelier myself, I thought pull requests were only for the relevant commit? Should I make another repo without Atelier?

I don't understand the necessary code for that and it's really not worth it for me to learn it just to do that.

Jul 06 '22 17:07 TheGuyWhoo

You need to split each pull request per branch, otherwise this pull request gets all the changes.

In any case, Atelier is currently blocked as we did not get permission to use their artwork.

Jul 06 '22 17:07 falkTX

Okay I removed it.

Jul 06 '22 17:07 TheGuyWhoo

I was wondering if I asked dev do include my dark versions in the official modules repo if that would make things easier if he accepted?

Aug 03 '22 17:08 TheGuyWhoo

Best to use upstream sources when possible, we can do the dark mode ourselves at runtime.

I checked on this finally, and there is a license issue. Opened a ticket at https://github.com/tomdasilva/Mojo/issues/4 Let's wait for the reply.

Sep 08 '22 10:09 falkTX