[WIP] Feature/add dbiz
not functional yet, needs work for dark panels and resolving of font licensing
dotmatrix font comes from https://dionaea.com/information/fonts.php which says the font is "freeware". this is not a valid license, it is questionable if CC-BY and freeware are even allowed to mix. it must be replaced for use in cardinal
The other font has details on https://www.dafont.com/rounded-elegance.font Seems to be a fix of 3 other fonts - "Giorgio", "Abeat By Ky" and "Ukiji"
On the comments the author says:
I inform everyone that this source is free for any type of use, whether private, public or commercial. Make a good use.
This is not a legally valid license. We need to check the other 3 fonts it is based on.
Hi, if needed I can change the font for adding my modules to Cardinal, I'm not a coder but let me know if I can help in any way ;)
@dBiz cheers! First would be to check if any of these included ones are your fancy -> https://github.com/VCVRack/Rack/tree/5551617afff182925940908eaf73a7d7361303cc/res/fonts
Other inspiration would be other module designs -> https://github.com/DISTRHO/Cardinal/blob/952df617e838a0d862678adef2a1dd170e56b222/docs/LICENSES.md#plugins
But we are still looking to maybe create a "font pool" from all the common ones, so we can minimize the number of static files we need to ship.
Yep no prob, I've replaced the dotmatrix with a given Rack one ;) Let me know if works
Ok, managed to resolve all conflicting module/type names and set darkpanel when loading the modules. But the panel switch needs some more work (library still looks light and we want to be able to switch entirely to light-mode as well).
Should also remove the menu item on setting dark as default for cardinal builds. Might need a patch?
Lets see what @falkTX thinks ;)
I'm open to any changes/suggestion/pull ;) my code skill needs for sure an improvement
I've update my pack with minor bugs and now seems to work as dark in browser, hope it helps ;)
@dBiz nice! Seems to work well :)
merged as 46dcb39eddebdbe5f85ab35aca23d15835c0fffe