DIRAC icon indicating copy to clipboard operation
DIRAC copied to clipboard

[9.0] DISET version of the TokenManager service

Open atsareg opened this issue 1 year ago • 2 comments

The DISET version of the TokenManager service is added. This will help to eventually get rid of all the Tornado services.

BEGINRELEASENOTES

*Framework NEW: DISET version of the TokenManager service

ENDRELEASENOTES

atsareg avatar Sep 14 '24 18:09 atsareg

Why not put this into 8.0? The TokenManager is the only tornado service I have

andresailer avatar Sep 18 '24 15:09 andresailer

For each and every service for which we have the DIPS and HTTPs version, we have 2 files:

  • a "NameOfHandler.py". This contains
class NameOfHandlerMixin:
  # logic end "export_"s here

class NameOfHandler(NotificationHandlerMixin, RequestHandler):
    pass
  • a "TornadoNameOfHandler.py". This contains
class TornadoNameOfHandler(NotificationHandlerMixin, TornadoService):
    pass

which should be respected also here. So, at a minimum you need to modify accordingly also the "TornadoTokenManagerHandler.py". Or, at the 2 VERY different one from the other?

BTW I think this should also go to v8.

fstagni avatar Sep 19 '24 09:09 fstagni

The 8.0 version of this one is in PR. As for the 9.0, I think we should scrap all the Tornado services related stuff (TokenManager was the last one in Tornado only). This would allow also to get rid of Tornado in the services framework leaving it only for the WebApp.

atsareg avatar Nov 18 '24 16:11 atsareg

Should be replaced by #7895 propagated from 8.0

atsareg avatar Nov 19 '24 12:11 atsareg