OracleDynamicParameters.Add( size ) documentation

[kbilsted]

Hi

Many thanks for this library!

Can you please document the optional parameter size on OracleDynamicParameters.Add()? The code was not obvious to me. Perhaps it is evident if you have more Oracle knowledge than I have.

Also what happens when you guess a size of 4000 but the result actually is larger?

While it may sound like a random parameter to document, I think these aspects are crucial to understand in order to be able to use this library.

many thanks

[epaulsen]

Sorry for the delayed response, missed this. First off, thank you for the kind words.

This library is a thin shim which enables Dapper to use native Oracle methods directly exposed through .net Oracle driver without Dapper knowing the internals of the Oracle driver. So for the Add method of OracleDynamicParameter we should ideally refer users over to the Oracle documentation for parameters. BTW: That can be found here: https://docs.oracle.com/cd/E11882_01/win.112/e23174/OracleParameterClass.htm#ODPNT1729

I do agree that documentation could definitely be improved.