Dustin L. Howett

Results 663 comments of Dustin L. Howett

The one risk I am aware of is that we *will* delete user color schemes that ONLY change the cursor or selection colors. I can add checks to avoid this,...

So! Because `_addOrMerge` is called during settings loading and we don't have a place to store "I did fixups" _outside of `FixupUserSettings`_, I opted to instead track the observable effects...

> "can ScratchpadPane be left out of the idl?"

So, I'll provide the counteropinion on this one. I think it's the right thing to do. Because we can be the default terminal on Windows, we will want to derive...

Hey, do you happen to have "mica4all" or "mica everywhere" (I can't remember the name!) installed?

Despite living in the same library, TerminalSettings and CascadiaSettings live in fundamentally different "layers" of the application. TerminalSettings is only where it is because it is used by the settings...

Does this let you get rid of the wacky inheritance tree from Tab/TabBase/TerminalTab/SettingsTab? If so, will you file followup work (and do it?)

I'm running this PR through the PGO build as well -- i will merge when it is done. @lhecker @zadjii-msft I need a re-review on the last push