gantt icon indicating copy to clipboard operation
gantt copied to clipboard

Duplicated taskUpdate when using multiselect module

Open yuriy-harbuzyuk opened this issue 5 years ago • 1 comments

When dragging a regular task while "multiselect" module is on, task update request is fired twice. I think updateTask is invoked from _finalize_mouse_up. As you can see below, _finalize_mouse_up invoked first time if multiselect is enabled (isMultiselect), and second time after the loop.

  on_mouse_up: function(e) {
  	var drag = this.drag;
  	if (drag.mode && drag.id) {
  		var config = timeline.$getConfig();
  		//drop
  		var task = gantt.getTask(drag.id);
  		var dragMultiple = this.dragMultiple;

  		if (drag.mode === config.drag_mode.move) {
  			if ((gantt.isSummaryTask(task) && config.drag_project) || (this._isMultiselect())) {
  				for (var i in dragMultiple) {
  					this._finalize_mouse_up(dragMultiple[i].id, config, dragMultiple[i], e);
  				}
  			}
  		}
  		this._finalize_mouse_up(drag.id, config, drag, e);
  	}
  	this.clear_drag_state();
  }

yuriy-harbuzyuk avatar Feb 20 '20 09:02 yuriy-harbuzyuk

Hello Yuriy, Thank you for informing about the issue. Looks like it happens when you drag a selected task, it is not reproduced while dragging the tasks that are not selected. I added it as a bug in our internal tracker. The dev team will fix it, but I cannot give you any ETA.

gearcoded avatar Mar 20 '20 09:03 gearcoded