modelskill icon indicating copy to clipboard operation
modelskill copied to clipboard
verified publisher icon DHI

Persistence using NetCDF groups

Open ecomodeller opened this issue 1 year ago • 3 comments

Should be cleaner than using a zip file.

This is a breaking change since it is not backwards compatible.

If useful, consider supporting both formats.

Any case, this PR is not be merged before we have released version 1.1.

Moreover, it requires xarray version > 2024.10.0 which Requires: Python >=3.10😳

ecomodeller avatar Oct 25 '24 12:10 ecomodeller

One line in a notebook is failing

cmp.where(cmp.data.windsector=="W").plot.timeseries();

I can't see that it is related to the changes in this PR, except for the new version of xarray.

ecomodeller avatar Oct 25 '24 14:10 ecomodeller

Seems like there is some kind of agreement in the scientific Python community to support three year old Python versions https://scientific-python.org/specs/spec-0000/

Which would exclude 3.9 released in October 2020.

ecomodeller avatar Oct 25 '24 16:10 ecomodeller

TODO:

  • [x] Re-enable legacy persistence method using zip file.
  • [x] convert persisted datasets to use groups.

ecomodeller avatar Jan 29 '25 11:01 ecomodeller