Ajout de metrique dans AT et approche multiresolution. Noemie Tasca, …
[stagiaire de Jacques-Olivier Lachaud]
PR not ready yet. Working on it.
Thanks a lot for contributing to DGtalTools, before submitting your PR, please fill up the description and make sure that all checkboxes are checked.
PR Description
Metric : Taking into account the metric in the discrete formulation of Ambrosio-Tortorelli. Multiresolution : Adding a multi-scale resolution in image restoration using Ambrosio-Tortorelli.
Checklist
- [x] Doxygen documentation of the code completed (classes, methods, types, members...).
- [x] Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
- [x] Check if it follows the tools structure described in CONTRIBUTING.md
- [ ] New entry in the ChangeLog.md added.
- [x] Update the readme with potentially a screenshot of the tools if it applies.
- [x] No warning raised in Debug
cmakemode (otherwise, Travis C.I. will fail).
Hi Noemie ! For the last three points, they are easily handled:
- ChangeLog.md : you can just edit the file, add your PR number and name and a short sentence describing your work.
- Readme.md: again, it is just editing the file and add a screenshot for marketing (not sure it is necessary since your tool produces the same output as at-u2-v0
- No warning in debug mode : you can toggle it on since the CI has passed. I'll have a look at your PR next week. Thanks
Hi @NoemieTasca @JacquesOlivierLachaud do you think that it is ready for review ? (or better waiting after 1.0 ?)
ping @JacquesOlivierLachaud can I review it ? I suppose yes since the check are greens ;)
Honnestly I had completely forgotten this PR and even the commits I made. I think you can have a look. This code is sufficiently independent of other programs to be merged quite safely.
I have to check this PR more. Noemie had a lot of weird problem when doing multi scale approaches. I do not know yet if it is a conceptual problem or simply a bug.
@NoemieTasca since news changes with CLI prog options were made, to help I PR on your branch the merge: https://github.com/NoemieTasca/DGtalTools/pull/1 You can perhaps merge to simplify the review ? (the conflict was not very complicated) (CC @JacquesOlivierLachaud )
In the PR I also apply new change with CL11 in link to previous PR.