DGtal icon indicating copy to clipboard operation
DGtal copied to clipboard

Published 20 hours ago • verified publisher icon DGtal-team

[wip] Dropping QT4 and Eigen is now required (and included using FetchContent)

Open dcoeurjo opened this issue 2 years ago • 2 comments

PR Description

Including eigen in DGtal (no more optional):

  • we use FetchContent to download the proper version at cmake time
  • EIGEN_ROOT can be used to specify alternative eigen install

Checklist

  • [ ] Unit-test of your feature with Catch.
  • [ ] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [ ] Documentation module page added or updated.
  • [ ] New entry in the ChangeLog.md added.
  • [ ] No warning raised in Debug mode.
  • [ ] All continuous integration tests pass (Github Actions & appveyor)

dcoeurjo avatar Nov 08 '21 16:11 dcoeurjo

@JacquesOlivierLachaud @kerautret @troussil could you please test this PR on your system ?

dcoeurjo avatar Sep 29 '22 06:09 dcoeurjo

Yes I look it

kerautret avatar Sep 29 '22 08:09 kerautret

All looks fine both from my computer on MacOS and also tested on linux servers with QT options. 👌🏻

kerautret avatar Oct 03 '22 12:10 kerautret

it seems fine (last LTS Ubuntu, even when QGLViewer and examples are enable)

troussil avatar Oct 04 '22 15:10 troussil

Thx

dcoeurjo avatar Oct 04 '22 18:10 dcoeurjo