redisql icon indicating copy to clipboard operation
redisql copied to clipboard

[FEATURE REQUEST] Add Docker support for redisql so that things like GitHub Actions can be used for CI/CD; and IDE setup is seamless.

Open stemount opened this issue 3 years ago • 4 comments

Describe the solution you'd like

Provide a docker compose solution so a maintainer or user can run this box in isolation of needing PostgreSQL/MySQL and Redis to test this.

Describe alternatives you've considered

A docker image could be appropriate for testing which combines Go, MySQL, PostgreSQL and/or Redis in one box, however it would require maintenance of upstream Docker images and there's no performance penalty using docker compose, a docker-compose template allows maintainers to just completely retrash/rebuild their development environment by services.

stemount avatar Oct 04 '21 20:10 stemount

I think an image would be better. I'll have some more feedback on the feature request soon.

DGKSK8LIFE avatar Oct 05 '21 08:10 DGKSK8LIFE

Ok so here was what I was thinking @stemount:

Containerization of redisql so that it could be integrated into a microservices architecture, run in an isolated manner, and invoked when needed, this way it would be platform agnostic and you could call the underlying internal lib thru gRPC or any other desired state transfer spec or RPC protocol. The only use case I see for a compose test architecture would be if we started using Github Actions to validate PRs or wanted to do chaos engineering on the lib when integrated into a production environment (which would either be separate or run subsequently from #33).

Conversely, this entire idea (and containerization itself) could be overkill and add undesired latency/configuration to the lib's functionality. If we want to support many different platforms/deployment methods etc then I think we should grow the project more (at least ~1.5k stars and ~10-15+ active users) and migrate to an isolated organization. Tell me what you think.

DGKSK8LIFE avatar Oct 06 '21 14:10 DGKSK8LIFE

Hello Steve , We need to mention base docker image as redis/postgres right?

StarTrooper08 avatar Oct 23 '21 16:10 StarTrooper08

Hello Steve , We need to mention base docker image as redis/postgres right?

Yes and also MySQL since redisql supports it, though it really depends on the user's choice.

DGKSK8LIFE avatar Oct 23 '21 20:10 DGKSK8LIFE