dfhack icon indicating copy to clipboard operation
dfhack copied to clipboard

Update stockpiles.lua

Open unboundlopez opened this issue 1 year ago • 3 comments

Added functionality to import export on the stockpile menu.

unboundlopez avatar Oct 13 '24 18:10 unboundlopez

pre-commit.ci autofix

unboundlopez avatar Oct 13 '24 18:10 unboundlopez

https://github.com/user-attachments/assets/0cb6f04d-5ad9-4235-b45e-e8e6a9a20960

unboundlopez avatar Oct 13 '24 19:10 unboundlopez

@myk002 Could you provide some context on https://github.com/DFHack/dfhack/commit/856237cfd3e92124b7cf3dab3e76ede850457d4c (Part of https://github.com/DFHack/dfhack/pull/3285)

It looks to me like the functionality provided by this PR was already partially implemented, but commented out, beforehand.

chdoc avatar Oct 13 '24 19:10 chdoc

Please give this PR a more descriptive name than "update stockpiles.lua". We often depend on being able to review code history to understand why code is the way it is, and commits and PRs with nondescript titles and descriptions are not helpful to this end.

ab9rf avatar Oct 31 '24 20:10 ab9rf

Updated the title.

unboundlopez avatar Oct 31 '24 22:10 unboundlopez

@myk002 Could you provide some context on 856237c (Part of #3285)

It looks to me like the functionality provided by this PR was already partially implemented, but commented out, beforehand.

Yeah, I got scared off from designing a UI that would make generated material filters and property filters intuitive. The stockpiles API is quite intimidating (and I say that even though I'm the one who wrote it). I was also completely burned out on stockpiles after the massive effort that went into updating the stockpiles plugin code so it could act as a backend for quickfort stockpile config scripting: https://docs.dfhack.org/en/stable/docs/guides/quickfort-user-guide.html#stockpile-configuration.

However, a simple approach like what this PR implements would at least be useful for copy/pasting stockpiles within a single fort, which is still a worthy use case.

myk002 avatar Dec 26 '24 06:12 myk002