dfhack icon indicating copy to clipboard operation
dfhack copied to clipboard

`makeown` should clear `enemy.army_controller_id`

Open ab9rf opened this issue 1 year ago • 1 comments

Based on this comment on discord, I did some code searches in 50.13 and discovered that, in at least some situations, when a unit is joined to a site its army_controller_id is set to -1 to indicate that it is no longer a part of an "army". makeown should probably do this. This appears to affect hostility determinations, based on other observations made in discord.

It may also be necessary to remove the unit and the unit's histfig from the army itself; whether this is needed requires further research.

ab9rf avatar Jun 26 '24 20:06 ab9rf

Further research should also be done on what would get the "Expel" button to appear, because it appeared for intelligent wilderness creatures I makeown-ed, but not the goblin snatchers.

Crystalwarrior avatar Jun 26 '24 20:06 Crystalwarrior

Fixed by https://github.com/DFHack/scripts/pull/1321

myk002 avatar Oct 05 '24 06:10 myk002