dfhack icon indicating copy to clipboard operation
dfhack copied to clipboard

`library/includes/wdirent.h` may be out of date

Open ab9rf opened this issue 1 year ago • 3 comments

this include was obtained from tronkko/dirent sometimes around 2011 when it was designed for use with MSVC 6.0. there's been some updates since then in the original source and we're long past MSVC 6.0

ab9rf avatar May 17 '24 01:05 ab9rf

should we be depending on a local fork of https://github.com/tronkko/dirent instead? it looks like there are (relatively) recent releases

myk002 avatar May 17 '24 01:05 myk002

i don't think that would be a bad approach

i dunno if there are material changes between what we're using and what is in tronkko's repo; i haven't looked that closely, and this isn't necessarily causing problems. mostly i was looking at this just to understand what it was and why it's there

ab9rf avatar May 17 '24 02:05 ab9rf

yeah, I was confused too. at least moving it to depends would make it clearer

myk002 avatar May 17 '24 15:05 myk002