Inhibit "error" message: Class not in symbols.xml: 'dfhack_lua_viewscreen@DFHack'

Open myk002 opened this issue 2 years ago • 3 comments

this confuses players who think that it indicates a problem. we could maybe filter dfhack viewscreens out where the error message is being printed?

Dec 19 '23 19:12 myk002

It's not an error message, and it has been reworded multiple times to make it clearer that it isn't an error. I don't really know how we can make it clearer. Maybe somewhere other than stderr.log, but it is really helpful to have these logged sometimes because they can be related to errors, especially during development for new DF versions.

Dec 19 '23 21:12 lethosor

I pointed out in Discord that this message should probably not be logged for any classes inside the DFHack namespace (which will require separate logic on Windows versus Linux).

Dec 20 '23 00:12 quietust

Also, my favorite suggestion from Discord was prefixing this line with INFO:.

Unfortunately with GCC mangling and our current implementation of doReadClassName(), the leading DFH in DFHack gets stripped out: https://github.com/DFHack/dfhack/blob/bbc79d70c04a993d84da591e8cd0bf18bab15075/library/Process-linux.cpp#L120

Dec 20 '23 05:12 lethosor