Dig-now Channel issue

[nutwick]

trafficstars

Dig-now seemed to mine instead of channel in this instance.

[myk002]

The issue (as Rose noticed from the screenshot on Discord) appears to be that dig-now is channeling out every alternate layer. What is likely happening is that after one layer is channeled out, the next layer becomes invalid for channeling due to the lack of rock (because the layer that was just channeled removed it), so that layer is skipped. The logic either needs to be updated to process levels in the opposite direction or otherwise handle this case.

I believe the code goes in the order it does to support successive levels of ramps, so the fixer for this issue should check that both channels and ramps work over multiple levels.

[cppcooper]

Oh, I forgot to open an issue about this in December. I totally forgot I encountered this.

I imagine running a check to detect this situation, then re-applying the designations and running the process again could also solve it. Though that does feel like more of a hack than solution.

[myk002]

I'm sure it can all be done in a single pass. It just needs a better algorithm than the one I wrote