dfhack icon indicating copy to clipboard operation
dfhack copied to clipboard

DFHack 50.05-alpha1 - Fastdwarf teleport not working

Open robindegen opened this issue 2 years ago • 13 comments

Running fastdwarf 1 1 prints the confirmation that teleporting is enabled, but the dwarves don't actually teleport. They do move faster however. Tested with the steam version.

robindegen avatar Jan 18 '23 22:01 robindegen

Seems that the bug not global as it works perfectly in my game. I have a mod from the workshop that already gives the dwarfs speed so I tried fastdwarf 0 1 and they started teleporting, I even tried fastdwarf 1 1 for science and they are faster too. Didn't try it out in "vanilla "tough as the release came midgame and I didn't make a specific world to try it out.

JezaGaia avatar Jan 19 '23 20:01 JezaGaia

My game is vanilla. I can make a video about it if needed. Let me know if you need more information or if i should try certain things.

robindegen avatar Jan 19 '23 20:01 robindegen

@JezaGaia what DFHack version are you using?

lethosor avatar Jan 20 '23 01:01 lethosor

@robindegen to confirm, what does fastdwarf 0 1 do for you?

And can you verify that help prints DFHack 50.05-alpha1 at the end, with no additional information in the version number?

lethosor avatar Jan 20 '23 01:01 lethosor

DFHack is ready. Have a nice day!
DFHack version 50.05-alpha1 (release) on x86_64

I recorded a video. I tried both again, and in neither cases do they teleport. With 1 1 they just move faster; thats it.

https://www.youtube.com/watch?v=3Zkm-DavidA

On an unrelated note; the hover and then click the option is very awkward to me; i keep trying to click the dfhack icon which makes things go away.

robindegen avatar Jan 20 '23 12:01 robindegen

@robindegen does the issue persist in alpha2 or later?

@wolfboyft any idea if https://github.com/DFHack/dfhack/pull/2374 could be related?

lethosor avatar Jan 26 '23 06:01 lethosor

@lethosor From what I can see a lot of things work since I'm seeing them blink around now; however hauling doesn't. For hauling they will still just move regularly (or fast with fastdwarf 1 1) and never teleport. I tested at least hauling blocks.

robindegen avatar Jan 26 '23 17:01 robindegen

So just to clarify: when they are currently holding an item and moving with it, they move quickly, but otherwise they teleport? What about when they are in a hauling job but haven't picked up the item yet?

Tachytaenius avatar Jan 26 '23 17:01 Tachytaenius

@wolfboyft I have to look in greater detail when exactly it works and when it doesn't when I have some time. I will get back to you about that.

robindegen avatar Jan 26 '23 17:01 robindegen

Can confirm they teleport for hauling with fastdwarf 0 1 and fastdwarf 1 1 in 47. I think that means this is a structs change?

Tachytaenius avatar Jan 26 '23 17:01 Tachytaenius

Could also be a DF behavior change in v50

lethosor avatar Jan 26 '23 18:01 lethosor

yeah, I'm pretty sure everything was working as intended in 0.47

myk002 avatar Jan 26 '23 20:01 myk002

I can confirm that teleportation does not work if they're using a wheelbarrow. It doesn't seem to matter if it is empty or not; if they have one; they will not teleport. It doesn't matter when the command was entered; the wheelbarrow causes them to never tp. The moment the dwarf I was following put away the wheelbarrow, he started teleporting around again.

It looks like teleporting does work if they're just carrying things by themselves in alpha2, but i have to look deeper if this is in all cases.

robindegen avatar Jan 27 '23 19:01 robindegen

Do you know if the wheelbarrow limitation was also present in 0.47?

The teleport feature works by teleporting dwarves to their "destination position", which is determined by DF. In a typical case where dwarves are walking, this is their final destination. When they're pushing a wheelbarrow, it's possible that DF is setting their destination tile to the next step along their path, and if that's the case, fastdwarf simply doesn't have the information it needs to teleport those dwarves.

You can visualize a unit's full path using devel/unit-path to check this, although I think it only works in 0.47 at the moment.

lethosor avatar Jan 31 '23 05:01 lethosor

the above still remains in 50.09-r4 but if I leave the teleport options running for too long I'll invariably end up with multiple teleporters stuck in random unexplored unmined locations, unable to move. with me only discovering their captivity due to the starving/dehydrated warning.

Caotical avatar Sep 18 '23 14:09 Caotical