dfhack icon indicating copy to clipboard operation
dfhack copied to clipboard

bprobe reports multiple stockpiles in the same tile

Open kelvie opened this issue 2 years ago • 3 comments

~ dfhack-run bprobe                                                                                                                      0 [21:48:13]
Building 1 - "Wood Stockpile #1" - type Stockpile (29)
Building 4 - "Activity Zone #1" - type Civzone (30), subtype Pen (88)
Building 431 - "Stockpile #11" - type Stockpile (29)

Of course this isn't actually possible image

kelvie avatar Jan 16 '23 05:01 kelvie

If it helps, this is actually the Wood stockpile (building 1), and stockpile 11 (building 431) is sort of all around it.

kelvie avatar Jan 16 '23 05:01 kelvie

It looks like it checks the if the cursor is in the rectangle created by the top left/bottom right coordinates, since stockpiles can now be all kinds of crazy shapes it looks like it'll need to check each tile of stockpiles instead of just the corners.

jcoskej avatar Jan 16 '23 21:01 jcoskej

yeah, i checked the code, it only checks for being in the bounding box of the building, no extents checking is done

it's always been like this, too going back all the way to 2012. i think the idea is that the user is expected to interpret the output so it's not so much wrong as "failing to meet user expectations"

ab9rf avatar Jan 16 '23 21:01 ab9rf