dfhack icon indicating copy to clipboard operation
dfhack copied to clipboard

[v0.47.05] gui/pathable: shift-esc to "exit to here" no longer works

Open lethosor opened this issue 2 years ago • 2 comments

It has the same behavior as Esc: exit to cursor, presumably introduced by the sidebar-mode-restoring changes.

Unsure what a suitable fix for v50 is. I'm mostly opening this to track a local patch I had to attempt to fix this, which didn't work:

diff --git a/gui/pathable.lua b/gui/pathable.lua
index 4ea4d64..875fe78 100644
--- a/gui/pathable.lua
+++ b/gui/pathable.lua
@@ -75,7 +75,9 @@ function Pathable:onInput(keys)
         self:dismiss()
         dfhack.gui.refreshSidebar()
     elseif keys.LEAVESCREEN_ALL then
+        print(self.saved_sidebar_mode)
         self:dismiss()
+        dfhack.gui.resetDwarfmodeView()
     elseif keys.CUSTOM_L then
         opts.lock_cursor = not opts.lock_cursor
     elseif keys.CUSTOM_D then

lethosor avatar Jan 03 '23 06:01 lethosor

Right now, at least, the v50 gui/pathable just disappears when ESC is hit and leaves the screen where it currently is.

myk002 avatar Jan 03 '23 06:01 myk002

There used to be two options: "exit to here" and "exit to cursor". They were different if the cursor was locked. If we don't support the keyboard cursor in v50, then this might be a moot point.

lethosor avatar Jan 05 '23 02:01 lethosor