dfhack icon indicating copy to clipboard operation
dfhack copied to clipboard

(feature request) building_hacks: add support for furnaces

Open KlonZK opened this issue 6 years ago • 6 comments

the lua frontend seems to be ready for furnaces already but the c++ part is not.

KlonZK avatar Jul 16 '18 08:07 KlonZK

IIRC you (whoever takes up that task) need to reimplement everything here to furnace. Probably by moving code out to be shared for both.

warmist avatar Jul 16 '18 09:07 warmist

Some more info after looking into the headers: you can't have furnaces connected to machines as they don't have machine info. So i'm not sure if it's even worth doing this?

warmist avatar Jul 29 '18 09:07 warmist

so it is entirely impossible to do, or can it be done by handling the machine stuff directly?

KlonZK avatar Jul 29 '18 10:07 KlonZK

Nothing is impossible per se. Just very very difficult.

In this case almost everything can be done easily (getMachineInfo could return some part of our memory - custom tracked or in some evil casting nightmare) but the hard part is how machines connect to each other (which needs work either way - it still has order of operations bug). The vmethod that is used for that is canConnectToMachine and i think in furnace case it might be not the same (i.e. return always false) as workshop.

warmist avatar Jul 29 '18 11:07 warmist

Adding machine info to furnaces is probably more trouble than it's worth, at least for now. It might not get saved properly even if we can construct it.

lethosor avatar Dec 28 '18 20:12 lethosor

In-progress work available in https://github.com/DFHack/dfhack/pull/1376

myk002 avatar Nov 29 '23 07:11 myk002