phptools-docs icon indicating copy to clipboard operation
phptools-docs copied to clipboard

Excluded files still available in peek definition

Open zeleniy opened this issue 1 year ago • 3 comments

Please, see bug description here: https://github.com/microsoft/vscode/issues/194299

zeleniy avatar Sep 27 '23 17:09 zeleniy

Thank you for reporting the issue.

Although, as said on https://github.com/microsoft/vscode/issues/194299#issuecomment-1737721116 , the "search.exclude" setting is not meant for the Peek to Definition functionality (or at least it's not specified, how the extension should behave)

Our extension respects "files.exclude" setting - the files there won't be indexed and/or navigated to.

jakubmisek avatar Sep 28 '23 13:09 jakubmisek

It seems excluded files still available on Peek to Definition panel. How can i exclude them from Definitions panel?

Screen Shot 2023-09-28 at 20 34 37

zeleniy avatar Sep 28 '23 17:09 zeleniy

thank you for trying the files.exclude setting so quick; it looks like a bug, let me try it and we'll see what we can do

jakubmisek avatar Sep 28 '23 18:09 jakubmisek