Phalanger icon indicating copy to clipboard operation
Phalanger copied to clipboard

Mono build fixes

Open weirdan opened this issue 9 years ago • 5 comments

This allows to build Phalanger on mono (at least mono/xbuild on Debian/sid) with Release configuration. Building with Debug doesn't seem to be possible, as it includes some VS specific assemblies (probably for unit-testing). I've been careful to wrap all mono-specific changes into Condition="'$(OS)' == 'Unix'", so these changes shouldn't break projects on windows/vs.

weirdan avatar Jan 06 '16 02:01 weirdan

these stubs should be moved into common.build.targets, the os targeting on the include for that file removed, and os targeting added to any step that cannot ever work on other systems:

<Target Name="Build" Condition="'$(OS)' == 'Unix'"/>
<Target Name="Clean" Condition="'$(OS)' == 'Unix'"/>

lucyllewy avatar Jan 24 '16 22:01 lucyllewy

re: stubs - how would that work? If I stub the Build target in the common file it would prevent all projects from building. Care to explain?

weirdan avatar Jan 25 '16 01:01 weirdan

oh, you're using the stubs to prevent building? I think I misunderstood their purpose then, where I assumed the stub was required for xbuild to build the project, so including the stub globally would have made sense under my assumption.

lucyllewy avatar Jan 25 '16 14:01 lucyllewy

That's right, I don't build Soap extension because there's some kind of a conflict, specifics of which elude me at the moment. Here's relevant part of the commit message:

Disabled Soap extension (there's a conflict between System.Data.dll and System.Web.dll)

weirdan avatar Jan 25 '16 14:01 weirdan

ok, in that case then sorry for the confusion over that. Feel free to completely disregard :-p

lucyllewy avatar Jan 25 '16 20:01 lucyllewy