Phalanger icon indicating copy to clipboard operation
Phalanger copied to clipboard

Published 20 hours ago • verified publisher icon DEVSENSE

Mono/Linux Improvements

Open kripper opened this issue 11 years ago • 4 comments

kripper avatar Feb 10 '14 22:02 kripper

very nice, I'll check the code and merge with master

jakubmisek avatar Feb 11 '14 14:02 jakubmisek

Agreed. try catch in production code is usually never a good thing.

robertleeplummerjr avatar May 30 '14 21:05 robertleeplummerjr

Could this be cherry-picked into current master? Things like proper PHP_OS value are useful, and that particular commit (kripper@4cb8a0c) applies cleanly even if the rest do not.

weirdan avatar Dec 30 '15 03:12 weirdan

Regarding catching specific exceptions, I prefer this PHP function to not throw stack traces by default.

We have been using Phalanger with Mono/Linux in production for big gov sites for over a year.

In our case, throwing unmanaged exceptions didn't sound as the best option. We prefer to just return NULL instead.

Besides, original PHP functions don't crash that way either on invalid dates.

Please cherry-pick or accept handling all exceptions by default. Remember perfection is enemy of good.

kripper avatar Dec 30 '15 04:12 kripper