Phalanger if php file changed, but it's datetime older, then phalanger will be load old assembly

if php file changed, but it's datetime older, then phalanger will be load old assembly

Open proff opened this issue 11 years ago • 7 comments

Aug 12 '13 18:08 proff

Sounds like expected behaviour to me, not an issue, since checking by datetime is reasonable.

Feb 10 '14 10:02 kripper

In phalanger behaviour must be same with php :) Php using changed file

Feb 10 '14 11:02 proff

Phalanger compares LastWriteTime of script files and current request time. If system time changes, it may cause issues.

Feb 10 '14 16:02 jakubmisek

After copying file a to file b, a.LastWriteTime==b.LastWriteTime && b.CreationTime==DateTime.Now. May be you should use max time?

Feb 11 '14 11:02 proff

Thats it,thanks. Will be fixed.

Feb 11 '14 11:02 jakubmisek

and with dynamic wrappers too. just encountered with this bug

Feb 11 '14 13:02 proff

I see.we should use ModifiedTime instead (max(CreationTime, LastWriteTime))

Feb 11 '14 13:02 jakubmisek