openbor icon indicating copy to clipboard operation
openbor copied to clipboard

Published 20 hours ago • verified publisher icon DCurrent

Fix build on modern systems.

Open resadent opened this issue 3 years ago • 3 comments

Mallinfo is deprecated. Changed all the occurrences with mallinfo2. Now builds in newer systems. Fixes #243.

resadent avatar Jun 03 '22 14:06 resadent

This is going to break compilation on systems without glibc >= 2.33. It doesn't look like there's a simple feature macro to check whether mallinfo2 is supported, so we should probably #include <features.h> and wrap the mallinfo2 call around an #if __GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 33) to remain compatible with everything.

Plombo avatar Jun 06 '22 21:06 Plombo

Sorry it took me so long to see this. I defer to @Plombo. Appreciate the contribution, but I can't approve a change that breaks that much across the board.

DCurrent avatar Jun 12 '22 03:06 DCurrent

Thank you for the comments and the review. I will have a look to @Plombo's comments to see if I can fix compilation on older builds 😀 .

resadent avatar Jun 13 '22 07:06 resadent