DreamShell icon indicating copy to clipboard operation
DreamShell copied to clipboard

Switch to -m4-single

Open MastaG opened this issue 1 year ago • 6 comments

I can confirm that it fully builds everything. However do not merge it until I have tested it later this week.

MastaG avatar Aug 20 '24 11:08 MastaG

@DC-SWAT I didn't find any regressions building with -m4-single instead of -m4-single-only. Perhaps just leave this open until KOS switches to -m4-single by default, then we can merge it. This way we can stay as close to KOS defaults as possible.

MastaG avatar Aug 22 '24 07:08 MastaG

I have did lots of testing and couldn't find any stability problems with this PR. The crashes at the games menu are also there without my PR, it's still WIP. Same goes for the crash when entering and exiting the "GD Play" menu without any disc inserted.

MastaG avatar Aug 26 '24 13:08 MastaG

I think it's worth waiting for KOS to switch to this by default. Because I try to keep the code as close to the default KOS as possible. Also I was told that this mode will not be removed from the GCC.

DC-SWAT avatar Sep 02 '24 04:09 DC-SWAT

absolutely, I just wanted to mention that I couldn't find any issues. I will rebase this once kos switches.

MastaG avatar Sep 04 '24 08:09 MastaG

@MastaG The time has come!

darcagn avatar Jan 22 '25 04:01 darcagn

@MastaG The time has come!

I agree. Now is the time for this.

DC-SWAT avatar Jan 27 '25 04:01 DC-SWAT