go-sqlmock
go-sqlmock copied to clipboard
DATA-DOG
feature: create rows columns and value from structs and slice by custom tag
Hello @Rennbon. That is a great addition. I noticed that you add a new dependency for testing here. Do you think you can rewrite the test cases using the vanilla testing package only as I'm not sure if there is a need to change that at the moment? @l3pp4rd do you agree?
I wonder why you ask me :)
Personally, I do use testify; but if this project does not use it yet and has the policy to avoid external testing libraries, I agree that introducing it there is not a good idea.
I wonder why you ask me :)
Personally, I do use testify; but if this project does not use it yet and has the policy to avoid external testing libraries, I agree that introducing it there is not a good idea.
Hey @AlekSi Sorry I tagged you wrongly. Glad to get some feedback though.
That is a great addition. I noticed that you add a new dependency for testing here. Do you think you can rewrite the test cases using the vanilla testing package only as I'm not sure if there is a need to change that at the moment? @l3pp4rd do you agree?
OK
@theodesp I removed testify and used reflect.DeepEqual to verify that it was as expected.
@Rennbon Thank you. Will try to test it this week a bit more.
Ok, hope to merge soon.
@l3pp4rd Is there a way to add this PR in Travis CI/CD pipeline please. It seems that I'm not able to see the test results in order to merge. Thank you.
Those are utility functions. They don't have to be in the sqlmock core. They could be published as a separate package.
Those are utility functions. They don't have to be in the sqlmock core. They could be published as a separate package.
From a usage perspective, this commit reduces mock writing complexity. If go-sqlmock implements this functionality directly, it will be easier for developers to use.