Ben Scholzen

Results 57 comments of Ben Scholzen

Well, i don't know if this conforms with the unix style. 0 usually means the application exited without errors, while anything else means "there was an error while executing the...

How about we follow the checkstyle way then, and use the count of "error" violations as exit code? See: http://checkstyle.2069334.n4.nabble.com/exit-code-of-checkstyle-not-zero-td2532939.html

I think it's better to follow the checkstyle example, as that allows to use Flitch output the same way as checkstyle.

Yeah but checkstyle is most implemented in the CI systems ;)… I think we can just iterate over $file->getViolations() after each analyzeFile() and count the number of violations which are...

Since I still see lots of commits coming in, I assume this is still work on progress?

I'll see that I can review all changes in the next week or two. Am a little busy at the moment.

If you are still interested, you could have a stab at creating a pull request.

With the new version now released, this is now a bucket list item for version 2.1.

Could you elaborate on what exactly Torrent Control is doing in that case? What is the workflow for that?