Video-LLaMA icon indicating copy to clipboard operation
Video-LLaMA copied to clipboard

Published 20 hours ago • verified publisher icon DAMO-NLP-SG

Possible bugs in LR scheduler

Open SAGNIKMJR opened this issue 1 year ago • 0 comments
trafficstars

Hi, do you think the following could be bugs in the lr scheduler?

  1. https://github.com/DAMO-NLP-SG/Video-LLaMA/blob/ae12557b8510a7cc94baa3d3aea58ea07f6de76a/video_llama/common/optims.py#L83 should be step=total_cur_step,?
  2. https://github.com/DAMO-NLP-SG/Video-LLaMA/blob/ae12557b8510a7cc94baa3d3aea58ea07f6de76a/video_llama/common/optims.py#L91 should be epoch=total_cur_step - self.warmup_steps,?
  3. https://github.com/DAMO-NLP-SG/Video-LLaMA/blob/ae12557b8510a7cc94baa3d3aea58ea07f6de76a/video_llama/common/optims.py#L93 should be max_epoch=self.max_epoch * self.iters_per_epoch - self.warmup_steps,?

SAGNIKMJR avatar Apr 11 '24 21:04 SAGNIKMJR